Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Option to (dis-)allow accelerated video drivers. #8819

Merged
merged 1 commit into from Mar 8, 2021

Conversation

TrueBrain
Copy link
Member

Closes #8812
Closes #8816

Motivation / Problem

Fully based on #8812, but with some differences. Main difference is that this shows an error when it fails to use hardware acceleration, and switches it off for next run.

image

Also, renamed the setting to Hardware acceleration, as that sounded more to the point for me.

Description

The video drivers using the OpenGL backend are currently our only
accelerated drivers. The options defaults to off for macOS builds and
to on everywhere else.

Main drawback of this approach, that there is now a video-driver specific callback in the generic driver factory (UsesHardwareAcceleration), and the SelectDriverImpl has video-driver specific checks. In #8812 this was done a lot nicer by having that more generic, meaning it would also work for music and sound.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

The video drivers using the OpenGL backend are currently our only
accelerated drivers. The options defaults to off for macOS builds and
to on everywhere else.
@TrueBrain TrueBrain merged commit b93d7dd into OpenTTD:master Mar 8, 2021
@TrueBrain TrueBrain deleted the setting_accel branch March 8, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants