Add: Option to (dis-)allow accelerated video drivers. #8819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8812
Closes #8816
Motivation / Problem
Fully based on #8812, but with some differences. Main difference is that this shows an error when it fails to use hardware acceleration, and switches it off for next run.
Also, renamed the setting to
Hardware acceleration
, as that sounded more to the point for me.Description
Main drawback of this approach, that there is now a video-driver specific callback in the generic driver factory (
UsesHardwareAcceleration
), and theSelectDriverImpl
has video-driver specific checks. In #8812 this was done a lot nicer by having that more generic, meaning it would also work for music and sound.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.