Skip to content

Commit

Permalink
Adjust server ranking
Browse files Browse the repository at this point in the history 
specificially, penalize servers that support both v4 and v5
Reasoning: We, as a project, have no interest in promoting servers
that intentionally restrict themselves to the feature set of an old,
potentially buggy version.
  • Loading branch information
@sfan5
sfan5 committed Mar 15, 2021
1 parent e37149a commit 9f144f3
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions server.py
View file
Expand Up @@ -201,8 +201,8 @@ def serverUp(info):
"mods": (False, "list", "str"),

"version": (True, "str"),
"proto_min": (False, "int"),
"proto_max": (False, "int"),
"proto_min": (True, "int"),
"proto_max": (True, "int"),

"gameid": (True, "str"),
"mapgen": (False, "str"),
Expand Down Expand Up @@ -371,6 +371,10 @@ def server_points(server):
if uptime < HOUR_SECS:
points -= ((HOUR_SECS - uptime) / HOUR_SECS) * 8

# reduction to 40% for servers that support both legacy (v4) and v5 clients
if server["proto_min"] <= 32 and server["proto_max"] > 36:
points *= 0.4

return points

with self.lock:
Expand Down

2 comments on commit 9f144f3

@MisterE123
Copy link

@MisterE123 MisterE123 commented on 9f144f3 Mar 15, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: hmm, looking closer, I see that multicraft servers are still high on the list, just not first. Seems reasonable.

@Festus1965
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they will be first even with this 'masking' some day again:

  • as minetest users getting less and less - counted in numbers and as % of all gamer in Minetest and MultiCraft - list
  • as so lower amount gamer in MT5 automatic lets rise MultiCraft-server
  • as of a bit missunderstanding where MultiCraft users come from at most: 0.4.x

solution:
count them ONLY as 0.4.x server and list them there

proofed:

  • my server Asia Thailand with 40 kids in and number one 5.x, attraction a LOT of miss-matches server connections
  • same server running under MultiCraft 2.0.0 ... massive similar amount of connections, now they just fail as of my password

the main problem is, that the mt users, special admin, don't see the truth, WHERE there costumers go: there are still 5.x on Top with 15 gamer most and they feel happy ... = blind to the truth that 5.x gamer get less and less ...

end even of this solution in mt list, guide people with NOT MT or MultiCraft to MultiCraft client ... more options, and solved the failure of 0.x and 5.x

remember, as of my counting a view days now: ON minetest-server gamer are between 22 and 33% of all gamer only now,
there will also the 40% for that servers points in list nothing change ...
most gamer can't join 5.x ... so they go 0.4.x or most now MultiCraft

Please sign in to comment.