Skip to content

Commit 9f144f3

Browse files
sfan5sfan5
committedMar 15, 2021
Adjust server ranking
specificially, penalize servers that support both v4 and v5 Reasoning: We, as a project, have no interest in promoting servers that intentionally restrict themselves to the feature set of an old, potentially buggy version.
1 parent e37149a commit 9f144f3

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed
 

Diff for: ‎server.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -201,8 +201,8 @@ def serverUp(info):
201201
"mods": (False, "list", "str"),
202202

203203
"version": (True, "str"),
204-
"proto_min": (False, "int"),
205-
"proto_max": (False, "int"),
204+
"proto_min": (True, "int"),
205+
"proto_max": (True, "int"),
206206

207207
"gameid": (True, "str"),
208208
"mapgen": (False, "str"),
@@ -371,6 +371,10 @@ def server_points(server):
371371
if uptime < HOUR_SECS:
372372
points -= ((HOUR_SECS - uptime) / HOUR_SECS) * 8
373373

374+
# reduction to 40% for servers that support both legacy (v4) and v5 clients
375+
if server["proto_min"] <= 32 and server["proto_max"] > 36:
376+
points *= 0.4
377+
374378
return points
375379

376380
with self.lock:

2 commit comments

Comments
 (2)

MisterE123 commented on Mar 15, 2021

@MisterE123
MisterE123
on Mar 15, 2021

EDIT: hmm, looking closer, I see that multicraft servers are still high on the list, just not first. Seems reasonable.

Festus1965 commented on Sep 3, 2021

@Festus1965
Festus1965
on Sep 3, 2021

they will be first even with this 'masking' some day again:

  • as minetest users getting less and less - counted in numbers and as % of all gamer in Minetest and MultiCraft - list
  • as so lower amount gamer in MT5 automatic lets rise MultiCraft-server
  • as of a bit missunderstanding where MultiCraft users come from at most: 0.4.x

solution:
count them ONLY as 0.4.x server and list them there

proofed:

  • my server Asia Thailand with 40 kids in and number one 5.x, attraction a LOT of miss-matches server connections
  • same server running under MultiCraft 2.0.0 ... massive similar amount of connections, now they just fail as of my password

the main problem is, that the mt users, special admin, don't see the truth, WHERE there costumers go: there are still 5.x on Top with 15 gamer most and they feel happy ... = blind to the truth that 5.x gamer get less and less ...

end even of this solution in mt list, guide people with NOT MT or MultiCraft to MultiCraft client ... more options, and solved the failure of 0.x and 5.x

remember, as of my counting a view days now: ON minetest-server gamer are between 22 and 33% of all gamer only now,
there will also the 40% for that servers points in list nothing change ...
most gamer can't join 5.x ... so they go 0.4.x or most now MultiCraft

Please sign in to comment.