Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8813: Misleading function name for selecting refresh rate #8836

Merged
merged 1 commit into from Mar 10, 2021
Merged

Fix #8813: Misleading function name for selecting refresh rate #8836

merged 1 commit into from Mar 10, 2021

Conversation

spnda
Copy link
Contributor

@spnda spnda commented Mar 10, 2021

Motivation / Problem

After the code review on #8813, the function does not select any refresh rate anymore.

Description

Simply renames the function to actually show what it does. Though there might be a better name for it?

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro merged commit 160a5f2 into OpenTTD:master Mar 10, 2021
@spnda spnda deleted the fixrefreshratefunc branch March 10, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain TrueBrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spnda @TrueBrain @LordAro