New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release OpenMSX 0.3.2 #1
Conversation
This PR is problematic because tries to do many unrelated things at once (including bumping the release number!!!), which is probably why it has been ignored for years. I suggest to split up this PR on a per-feature / per-bugfix basis. And drop the "release" portion of it entirely; there are other things that need fixing as well (see #7, #8, #9). |
Also, what exactly does this "optimized MIDI data" entail? It can mean a lot of things, and I'd like some documentation on what was actually done. (Sure I could go find/write a tool to compare the tracks, but that seems overkill.) |
I have more questions. It is about this:
But why? What was wrong with the old track? What do you mean with “fixed version”? Is one of the current tracks broken? |
Okay, so have done some research on this. So it appears to me the problem this PR attempts to fix are real.
Source: https://dev.openttdcoop.org/issues/8623 I'm still not sure why this optimization is neccessary, but I am definitely not a MIDI expert, don't ask me! Also, I have now figured out the rationale behind 'Keep on rolling', see #12. I suggest to do the following:
|
The 'Keep on rolling' track has been included into OpenMSX! Now the other major part in this PR is the optimization stuff. So I have no idea about MIDI, I am not an expert in this area, but it would be nice if someone more knowledgable about MIDI could look at our current MIDI files and check if there is any problem, and also check if this PR is doing things right. @DevanWolf claims to have fixed something broken about OpenTTD journey:
https://www.tt-forums.net/viewtopic.php?p=1220145#p1220145 It is unclear if the other files were “broken” as well, or if it was just a optimization for file size. :-/ So since this PR includes a possible bugfix, this is worth looking into. |
Going to go ahead and close this now, as most things have been superceded by others. Feel free to open new PR(s) for the relevant remaining things |
I decided to make a fixed and more compact version of OpenMSX as 0.3.2 which includes the following:
And some more text file corrections