The sticky positioned element should reset the scroll to an unshifted position by any operation #28098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 16, 2021
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2727895
branch
from
af077b4
to
27c8bda
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2727895
branch
from
27c8bda
to
67933fe
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2727895
branch
from
67933fe
to
6843d8f
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2727895
branch
2 times, most recently
from
ed9cce3
to
0950d2b
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2727895
branch
2 times, most recently
from
45eac9f
to
ebd8009
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2727895
branch
5 times, most recently
from
7e0d5e1
to
c952b8f
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2727895
branch
from
c952b8f
to
a64c109
Compare
… position by any operation When the sticky element takes the operation, it keeps the sticky offset to move its position. However, According to the specification [1], the scroll position should be reset by any operation to that element. Therefore, pass kIgnoreStickyOffset to AbsoluteToLocalRect() for removing sticky-position offset which is 'unshifted-position'. [1] https://www.w3.org/TR/css-position-3/#stickypos-scroll Bug: 664246, 1178622 Change-Id: I7b9e42d1274894a0f3282316a2eb69d0d10c5530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2727895 Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Seokho Song <0xdevssh@gmail.com> Cr-Commit-Position: refs/heads/master@{#878763}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2727895
branch
from
a64c109
to
ab4bda8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the sticky element takes the operation, it keeps the sticky offset to move its position.
However, According to the specification [1], the scroll position should be reset by any operation to that element.
Therefore, pass kIgnoreStickyOffset to AbsoluteToLocalRect() for removing sticky-position offset which is 'unshifted-position'.
[1] https://www.w3.org/TR/css-position-3/#stickypos-scroll
Bug: 664246, 1178622
Change-Id: I7b9e42d1274894a0f3282316a2eb69d0d10c5530
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2727895
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Seokho Song <0xdevssh@gmail.com>
Cr-Commit-Position: refs/heads/master@{#878763}