Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factories for new-style discrete trajectories #3147

Merged
merged 5 commits into from
Oct 10, 2021

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Oct 10, 2021

friend class physics::DiscreteTrajectoryIteratorTest;
friend class physics::DiscreteTrajectorySegmentTest;
template<typename F>
friend class testing_utilities::internal_discrete_trajectory_factories::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of internal is that we should never write internal_𒇧𒇧:: except in the usings that export those names—otherwise we might use things that are in that namespace only because they are a convenience using. Move that to testing_utilities (it’s a testing utility) and use FORWARD_DECLARE_FROM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@eggrobin eggrobin added the LGTM label Oct 10, 2021
@pleroy pleroy merged commit 91dd45b into mockingbirdnest:Ondelette Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants