Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiscreteTrajectoryIterator #3142

Merged
merged 25 commits into from
Oct 9, 2021
Merged

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Oct 8, 2021


private:
using Timeline = internal_discrete_trajectory_types::Timeline<Frame>;

// Optional because we cannot construct a point iterator in the end segment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to deal with the end segment at all? We could represent the end of the trajectory as the end of the last segment, where any trajectory has at least one segment (which may be empty).

@eggrobin eggrobin added the LGTM label Oct 8, 2021
@pleroy
Copy link
Member Author

pleroy commented Oct 9, 2021

retest this please

Sorry, something went wrong.

@pleroy pleroy merged commit 9324301 into mockingbirdnest:Ondelette Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants