Add: Warn when ternary operator results are not read only #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #241
For
guard ? expr_true : expr_false
, firstguard
is evaluated, then stored as guard, and it's opposite stored as !guard. Then some magic happens for the result, it's translated as!guard * expr_false + guard * expr_true
, meaning both expressions are evaluated in any case.Warn if any of the expression is not read only is a small improvement but won't prevent side effects.
The ideal solution would be to convert the ternary into a full action 2 in this case, but it's really not trivial to implement.