Fix: don't allow deleting SettingDesc to prevent compilers getting confused #9390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9386.
Alternative to #9389. Closes #9389.
Motivation / Problem
MacOS said: BOOOO
GCC said: fuck this shit
Similar to #9389, this shows that the core problem is not so much the
std::string
, but more the default dtor.Description
Please don't accept this PR. I just wanted it here to list it for history, and hopefully someone can discover a proper solution. This triggers a bunch of warnings, and is just a bit nasty.
And no, you cannot do
~SettingDesc() = delete
, as then sub-classes cannot use the ctor ofSettingDesc
to create its object.The first commit removes
unique_ptr
from the code-base, and might in general be a good idea to accept in the code-base. I can create a separate PR for that if this is wanted.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.