Fix: disable join button in online players window when the company is an AI #9369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
In the Online Players window, the Join Company button is displayed for AI companies. Clicking on it as an admin would move the admin to that company. Clicking on it as a client does send a command over the network only to be forbidden to be joined.
Description
This fix disables the Join Company button for AI companies.
Limitations
I am assuming the company_id exists at that point. If the company doesn't exist,
Company::Get(company_id)
is gonna crashChecklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.