Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passenger subsidies don't check if houses actually accept Passengers #9385

Closed
2TallTyler opened this issue Jun 19, 2021 · 3 comments
Closed

Passenger subsidies don't check if houses actually accept Passengers #9385

2TallTyler opened this issue Jun 19, 2021 · 3 comments
Labels
component: NewGRF This issue is related to NewGRFs enhancement Issue would be a good enhancement; we accept Pull Requests!

Comments

@2TallTyler
Copy link
Member

Version of OpenTTD

1.11.2

Expected result

If my house set doesn't accept Passengers, the game will not offer subsidies to deliver Passengers from one town to another.

Actual result

I'm developing an experimental industry NewGRF where passengers ("Workers") are delivered to industries for production, and are not accepted by my NewGRF houses. The game offers subsidies for bringing Workers from one town to another, even though houses in that town do not accept Workers.

Note that I am using both the original cargo ID and label PASS for Workers, for compatibility with other NewGRFs including old house sets and vehicles with cargo subtype refits for liveries.

Steps to reproduce

  1. Load the two NewGRFs in the .zip file below - Improved Town Layouts 1.4.0 beta 3 and Industries of the Caribbean 0.0.0, or just load the save (all other NewGRFs are on Bananas).
  2. Ensure that CargoDist is in Manual mode for Passengers.
  3. Wait for subsidies to be offered.

Subsidy_Demo.zip
@James103
Copy link
Contributor

Does the same apply for Mail as well? In other words, if no town will ever accept Mail, but some towns do produce Mail, then there should be no subsidies between towns for Mail.

@2TallTyler
Copy link
Member Author

I suspect so, but have not tested this.

@2TallTyler 2TallTyler added enhancement Issue would be a good enhancement; we accept Pull Requests! component: NewGRF This issue is related to NewGRFs labels Oct 19, 2022
@2TallTyler
Copy link
Member Author

I'm no longer doing (these specific) stupid things with NewGRFs, and don't expect anyone else to encounter this issue. Fixing it would probably be TMWFTLB.

@2TallTyler 2TallTyler closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: NewGRF This issue is related to NewGRFs enhancement Issue would be a good enhancement; we accept Pull Requests!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@James103 @2TallTyler