Fix nullptr dereference when autoreplacing vehicle with no orders in GetIncompatibleRefitOrderIdForAutoreplace #9387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
A null pointer dereference occurs when GetIncompatibleRefitOrderIdForAutoreplace is called on a vehicle with no orders, such that the order list is null.
(This also includes autoreplacing of free-wagon chains).
This was introduced in PR #8169.
Description
Handle the case where the order list is null in GetIncompatibleRefitOrderIdForAutoreplace.
Limitations
N/A
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.