nandland_go: reorder 7-segment displays #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would argue for left-to-right ordering, for one reason: while for purely numeric displays this makes sense, 7-segment displays are also used to display a subset of letters, and 14-segment displays the full set of them. It would be particularly inconsistent to have 7-segment and 14-segment display resources to use a different ordering. |
|
Fair enough, then I will just fix the DE10 Lite 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schematics of the Nandland Go number the 7-segment displays from left to right as 1 and 2, and the original commit introducing the Nandland Go numbers the 7-segment displays from left to right. However, the DE10 Lite board numbers the 7-segment displays from right to left. We should probably be sticking to one of the two orders and avoid introducing inconsistencies between boards like this. The right to left ordering probably makes the most sense, as the very first display would be used to display the least-significant nibble. So this pull request changes the order of the 7-segment displays for the Nandland Go to follow the same order as used for the DE10 Lite.
If we instead prefer left to right ordering, then that is fine with me too. I can have a look at the other boards that feature 7-segment displays to ensure the ordering is consistent at least.