Fix #9392: Return a valid value with GetBuildWithRefitCapacity when AIs are maxed out in vehicles #9393
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
fixes #9392
Description
The problem is solved by allowing a unit number of 0 for temporary vehicles using
DC_QUERY_COSTflag which is passed byGetBuildWithRefitCapacity.Limitations
I'm not really sure this will work in all cases.
refittingandsubflagsand the temporaryvthat may and may not exist and then theDC_EXECand non exec modes make it quite complex to test every scenario.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.