Codechange: [OSX] Use more exact enum names where introduced with the 10.12 SDK. #9394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only 10 first warnings are reported in #9391 CI summary, there are more in the build log. |
… 10.12 SDK. The enum values still have the exact same numerical values, but the 10.12 SDK introduced more explicit names (e.g. like NSEventTypeApplicationDefined instead of NSApplicationDefined) for several enum constants. Use them when available.
michicc
force-pushed
the
pr/osx_deprecated
branch
from
943ed8d
to
2f2e241
Compare
TrueBrain
approved these changes
Jun 22, 2021
LordAro
reviewed
Jun 22, 2021
| @@ -12,6 +12,8 @@ | |||
| #include "../../stdafx.h" | |||
| #include "../../os/macosx/macos.h" | |||
|
|
|||
| #define GL_SILENCE_DEPRECATION | |||
There was a problem hiding this comment.
This would benefit from a comment, I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem / Description
The OSX 10.12 SDK introduced various more logical and exact enum/constant names for various things.
As the old variants where marked deprecated, building for newer OSX versions produces compiler warnings.
Limitations
I added
#ifdefs where needed as master as of right now is still marked as 10.9 minimum. If the minimum ws bumped to 10.12, these wouldn't be needed. The pasteboard change is 10.6+.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.