Rewrite use of socket.error and socket.timeout errors #29362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of these changes are made by pyupgrade, but it doesn't simplify use of socket.timeout. socket.error is now an alias of OSError: https://docs.python.org/3/library/socket.html#socket.error socket.timeout is now a subclass of OSError: https://docs.python.org/3/library/socket.html#socket.timeout
wpt-pr-bot
added
infra
serve
wave
wpt
wptrunner
jgraham
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of these changes are made by pyupgrade, but it doesn't simplify use
of socket.timeout.
socket.error is now an alias of OSError:
https://docs.python.org/3/library/socket.html#socket.error
socket.timeout is now a subclass of OSError:
https://docs.python.org/3/library/socket.html#socket.timeout