Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Link note results to fragments #4947

Closed
ThiefMaster opened this issue Jun 14, 2021 · 0 comments · Fixed by #4950
Closed

Search: Link note results to fragments #4947

ThiefMaster opened this issue Jun 14, 2021 · 0 comments · Fixed by #4950
Assignees
Projects
Milestone

Comments

@ThiefMaster
Copy link
Member

We use the event_notes.view endpoint right now which just prints the note without any UI around it. This doesn't look amazing.

For meetings we could redirect to a new URL fragment (similar to what we use for session/contribution/subcontribution permalinks, just with a -note appended) which should then automatically expand that note (probably w/ JavaScript).

For conferences I would keep the current behavior as they do not have notes (unless someone created them before changing the type to conference).

Note that the event_notes.view endpoint itself needs to be left intact since this is also used for note permalinks. We could include some new query string arg like from_search=1 which triggers the redirect, or just add a new endpoint that only redirects.

@ThiefMaster ThiefMaster created this issue from a note in Release 3.0 (To do) Jun 14, 2021
@ThiefMaster ThiefMaster added this to the v3 milestone Jun 14, 2021
@ThiefMaster ThiefMaster moved this from To do to In progress in Release 3.0 Jun 15, 2021
Release 3.0 automation moved this from In progress to Done Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 3.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants