[ResourceTiming]: Extend TAO-match.html test to cover more resource types #29364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 14, 2021
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2956309
branch
4 times, most recently
from
3350b77
to
8bf527a
Compare
…ypes Since we have different code paths for loading different types of resources, this CL adds tests for Timing-Allow-Origin parsing/checking that exercise more resource types than before. This test is actually failing right now for Chrome but should pass in other browsers. Part of the reason to land this now is to see if other browsers will need fixes too. Bug: 1218565 Change-Id: Id274ec1fd914f62d3b805d4d69f81f2945a8baaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2956309 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#893912}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2956309
branch
from
8bf527a
to
0a673bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have different code paths for loading different types of
resources, this CL adds tests for Timing-Allow-Origin parsing/checking
that exercise more resource types than before.
This test is actually failing right now for Chrome but should pass in
other browsers. Part of the reason to land this now is to see if other
browsers will need fixes too.
Bug: 1218565
Change-Id: Id274ec1fd914f62d3b805d4d69f81f2945a8baaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2956309
Commit-Queue: Tom McKee <tommckee@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#893912}