Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation of numbered autosaves is confusing #9396

Closed
Taschi120 opened this issue Jun 23, 2021 · 1 comment · Fixed by #9397
Closed

Rotation of numbered autosaves is confusing #9396

Taschi120 opened this issue Jun 23, 2021 · 1 comment · Fixed by #9397

Comments

@Taschi120
Copy link
Contributor

Taschi120 commented Jun 23, 2021

Version of OpenTTD

master, revision 37116a7, any OS

Expected result

When the game makes a new autosave, it should
a) check if there is a free "autosave slot" and use it
b) if no autosave slots are free, overwrite the oldest autosave

Actual result

The first autosave after starting OpenTTD will always be called "autosave0", followed by "autosave1" and so on. When exiting and restarting OpenTTD, the next autosave will again be called "autosave0" because the counter resets.

In some cases, this might end up actually overwriting the newest autosave first, which is highly unintuitive and unexpected.

Steps to reproduce

Start the executable, start a new game, fast-forward until it has created a couple of autosaves. Exit & restart the executable, start a new game, fast-forward until a new autosave is created. Check file creation dates in the autosave folder.

Note that the "keep_all_autosave" settings has to be "false", which it is by default.

@Taschi120
Copy link
Contributor Author

I'll see if I can fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant