Update sticky position pushed beyond scrollable range test. #29368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 14, 2021
The css-position spec[1] was updated to suggest that sticky positioned elements are only shifted after layout within their containing block. This would imply that the now unified behavior across browsers matches the new spec expectations. This updates the test to match what the browsers do. [1] https://drafts.csswg.org/css-position-3/#stickypos-insets Bug: 752022 Change-Id: Ic95d32948f9088ae4592a3de78d6ac0a58db8183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2960015 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#892805}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2960015
branch
from
1199108
to
b09453c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The css-position spec[1] was updated to suggest that sticky positioned
elements are only shifted after layout within their containing block.
This would imply that the now unified behavior across browsers matches
the new spec expectations. This updates the test to match what the
browsers do.
[1] https://drafts.csswg.org/css-position-3/#stickypos-insets
Bug: 752022
Change-Id: Ic95d32948f9088ae4592a3de78d6ac0a58db8183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2960015
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892805}