[wpt] Fix grid aspect-ratio tests. #29369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 14, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2961536
branch
from
07b0997
to
b4c62df
Compare
There two tests were asserting that "min-width: auto" would clamp the inline-size to the available inline-size, even though we had a transferred inline-size. (Firefox has the same behaviour as us if "min-width: 0"). This updates the tests to respect the transferred inline-size. Bug: 1203090 Change-Id: I02e10d3393f74cce0979b483629d1d6cea33d10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2961536 Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#892731}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2961536
branch
from
b4c62df
to
303c8d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There two tests were asserting that "min-width: auto" would clamp the
inline-size to the available inline-size, even though we had a
transferred inline-size.
(Firefox has the same behaviour as us if "min-width: 0").
This updates the tests to respect the transferred inline-size.
Bug: 1203090
Change-Id: I02e10d3393f74cce0979b483629d1d6cea33d10d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2961536
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892731}