New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted C-string -> std::string conversions in network #9371
Conversation
a25fb05
to
a9acc07
Compare
…of the file that is downloading
cd86685
to
4be0d8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YOLO!
4be0d8a
to
db41132
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
@@ -1272,7 +1272,7 @@ static void AILoadConfig(IniFile *ini, const char *grpname) | |||
continue; | |||
} | |||
} | |||
if (item->value.has_value()) config->StringToSettings(item->value->c_str()); | |||
if (item->value.has_value()) config->StringToSettings(*item->value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather use item->value.value()
but... https://twitter.com/timur_audio/status/1184424350105161730?lang=nl
Motivation / Problem
The ongoing conversion of C-string to std::string.
Description
All kinds of small, but scattered in networking code, changes to go from C-strings to std::string.
Limitations
Contains #9372.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.