Integrate COOP in PolicyContainer #28128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 18, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2565243
branch
10 times, most recently
from
4284a90
to
53cfdc9
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2565243
branch
9 times, most recently
from
3edc152
to
a84cc2b
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2565243
branch
3 times, most recently
from
e21572e
to
fcadaaf
Compare
This adds Cross-Origin Opener Policy to the policy container. This was previously within [1], which was then split into COOP and COEP specific CLs. With this COOP inheritance is handled by the PolicyContainer. PolicyContainer does not handle the inheritance from the opener during a new window creation, given that COOP inheritance differs significantly: - It inherits from the top frame of the opener, if the opener is same-origin with its top frame. Further details in [2]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2490046/. [2] https://docs.google.com/document/d/1CnG8IWCXencWxmsQMDt9JHUucfpbWXjgknRjquzquV0/edit# Bug: 1153648 Change-Id: I77bb56bb0d6cd5c8f1523c14487817e970cb0bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565243 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#877388}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2565243
branch
from
fcadaaf
to
f945772
Compare
|
The changed tests are flaky on both Chrome Dev and Firefox nightly (this could be new or pre-existing flakes). Chrome Dev unstable results
Firefox Nightly unstable results
|
|
Filed crbug.com/1205423. I'll force merge this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Cross-Origin Opener Policy to the policy container.
This was previously within [1], which was then split into COOP and COEP
specific CLs.
With this COOP inheritance is handled by the PolicyContainer.
PolicyContainer does not handle the inheritance from the opener during
a new window creation, given that COOP inheritance differs significantly:
same-origin with its top frame.
Further details in [2].
[1] https://chromium-review.googlesource.com/c/chromium/src/+/2490046/.
[2] https://docs.google.com/document/d/1CnG8IWCXencWxmsQMDt9JHUucfpbWXjgknRjquzquV0/edit#
Bug: 1153648
Change-Id: I77bb56bb0d6cd5c8f1523c14487817e970cb0bd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565243
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/master@{#877388}