Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes #62

Merged
merged 4 commits into from Mar 23, 2021
Merged

Some fixes #62

merged 4 commits into from Mar 23, 2021

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Mar 23, 2021

Presume that's all correct anyway. Usual amount of testing done (none)

Partial fix for #61 - just hardcode the "1.2.0" string in the error message. I played around with getting rid of STR_GRF_NAME, but concluded you'd have to rip apart the build system to do so (which is terrifying, and probably needs doing at some point anyway). {TITLE} looks similar to a {} directive anyway, which most translators know not to touch.

Also updated the URL in the description

@TrueBrain
Copy link
Member

TrueBrain commented Mar 23, 2021

Possibly a few of these commits also need to be cherry-picked to OpenSFX / OpenMSX.

Well, maybe only one, the first. Don't know :)

@TrueBrain
Copy link
Member

{TITLE} is fine; OpenTTD is full of these kind of strings. I am pretty sure when they get to OpenGFX, they are trained sufficiently to handle that heavy burden of not touching it :D

@LordAro LordAro merged commit 9e54077 into OpenTTD:master Mar 23, 2021
@LordAro LordAro deleted the some-fixes branch March 23, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants