Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix f0f96e31: [OpenGL] Signed/unsigned warning. #8882

Closed
wants to merge 1 commit into from
Closed

Fix f0f96e31: [OpenGL] Signed/unsigned warning. #8882

wants to merge 1 commit into from

Conversation

michicc
Copy link
Member

@michicc michicc commented Mar 21, 2021

Motivation / Problem

comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]

Description

Change integer signedness.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@michicc michicc closed this Mar 21, 2021
@michicc michicc deleted the pr/fix_warn branch March 21, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain TrueBrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michicc @TrueBrain