-
-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Press ctrl to build diagonal rivers in Scenario Editor #8880
Merged
+20
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
reviewed
Mar 21, 2021
d3fe2e1
to
0bd9f44
Compare
LordAro
previously approved these changes
Mar 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it
Tile iterator is leaked. |
JGRennison
added a commit
to JGRennison/OpenTTD-patches
that referenced
this pull request
Mar 25, 2021
reldred
pushed a commit
to reldred/OpenTTD-patches
that referenced
this pull request
Mar 25, 2021
0bd9f44
to
e34f94d
Compare
LordAro
reviewed
Mar 25, 2021
e34f94d
to
d9b93f7
Compare
LordAro
reviewed
Mar 25, 2021
d9b93f7
to
3047c85
Compare
LordAro
reviewed
Mar 25, 2021
0e6c5db
to
30acfd3
Compare
LordAro
previously approved these changes
Mar 25, 2021
michicc
reviewed
Mar 31, 2021
30acfd3
to
bf4eb07
Compare
michicc
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
This is a JGRPP patch, created by @JGRennison. I am simply upstreaming it.
Description
In Scenario Editor, pressing ctrl makes a diagonal selector for the river tool — just like the Bomb tool.
The canal tool is unchanged, both in SE and in-game.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.