Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix f0f96e31: [OpenGL] warning: comparison of integer expressions of different signedness. #8881

Merged
merged 1 commit into from Mar 21, 2021

Conversation

frosch123
Copy link
Member

Motivation / Problem

src/video/opengl.cpp: In instantiation of ‘void ClearPixelBuffer(size_t, T) [with T = unsigned int; size_t = long unsigned int]’:
src/video/opengl.cpp:930:50:   required from here
src/video/opengl.cpp:890:20: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
  for (int i = 0; i < len; i++) {
                  ~~^~~~~
src/video/opengl.cpp: In instantiation of ‘void ClearPixelBuffer(size_t, T) [with T = unsigned char; size_t = long unsigned int]’:
src/video/opengl.cpp:937:39:   required from here
src/video/opengl.cpp:890:20: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]

Description

Moo.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@michicc michicc changed the title Fix: warning: comparison of integer expressions of different signedness. Fix f0f96e31: [OpenGL] warning: comparison of integer expressions of different signedness. Mar 21, 2021
@michicc michicc merged commit 0230624 into OpenTTD:master Mar 21, 2021
@michicc michicc added backport requested This PR should be backport to current release (RC / stable) component: OpenGL labels Mar 21, 2021
2TallTyler pushed a commit to 2TallTyler/OpenTTD that referenced this pull request Mar 29, 2021
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Mar 30, 2021
TrueBrain pushed a commit that referenced this pull request Apr 1, 2021
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable) component: OpenGL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants