New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add synth_design_options override for vivado #602
Conversation
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
=======================================
Coverage 81.50% 81.51%
=======================================
Files 49 49
Lines 6461 6463 +2
Branches 1287 1287
=======================================
+ Hits 5266 5268 +2
- Misses 1007 1008 +1
+ Partials 188 187 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept looks reasonable, but this will not be merged until #563 is, so you might want to hold up updating this PR until that happens. I'll try to do that soon.
nmigen/vendor/xilinx_7series.py
Outdated
@@ -108,7 +108,7 @@ def _part(self): | |||
read_xdc {{file|tcl_escape}} | |||
{% endfor %} | |||
{{get_override("script_after_read")|default("# (script_after_read placeholder)")}} | |||
synth_design -top {{name}} | |||
synth_design -top {{name}} {{get_override("synth_design_options")|default("# (synth_design_options placeholder)")}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elsewhere we use opts
, so this should be called synth_design_opts
.
Re-opening with proper branch name so I can merge locally. Sorry for the hassle |
Apparently the only way to pass options for synthesis in Vivado non-project mode is to add the arguments to the synth_design tcl command directly.
This PR adds an override to the xilinx_7series.py.
One use case is to inspect the synthesized design in Vivado with the following overrides in
platform.build
:There might be a more elegant/generic way of doing this for other workflows/platforms (environment variables?).