Feature: Configurable rainforest line height #8879
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
This is a patch created by @reldred and @JGRennison. I am simply upstreaming their work from JGRPP, with their consent.
Currently, rainforest height is 1/4 of the chosen
Maximum map height
. This is not intuitive nor is it explained anywhere.More importantly, it also does not allow all-green sub-tropic maps, since the minimum maximum height is 15. This is true even for heightmaps — the only workaround is to bulldoze all the desert in Scenario Editor, then replant rainforests by hand (rainforests are defined by rainforest trees, which spawn only in rainforest land, so you need to plant them manually to create rainforest land).
Description
This changes the rainforest line height to be controlled the same way as the snow line height, both in Settings and during map generation.
From reldred's PR to JGRPP:
If you set the rainforest line height to 1, you get all rainforest! Water towers don't spawn, but the same is true for farms and forests for certain snow line settings, so I don't think we need to worry about players breaking this.
Limitations
I have not done a savegame bump before, so please check to ensure I've done this correctly.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.