CSP: Improve WPTs inside workers #28169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 22, 2021
This change improves Web Platform Tests for Content Security Policy inside shared workers, by: 1) Fixing a test with CSP: connect-src 'self' that could not fail because of CORS requests being blocked independently of CSP. 2) Adding assertions that we raise securitypolicyviolation events for CSP violations. 3) Adding a test for Content Security Policies in report-only mode. While testing this, I noticed that debug versions of chrome would crash when checking the disposition of a securitypolicyviolation event from a Worker. This because of the thread-safety DCHECKs of WTF::String. For addressing this, I needed to create new global static strings "enforce" and "report". Change-Id: I9c91b1a60eac82279dd74e8bb640dde2ada9cf6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2775564 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#870899}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2775564
branch
from
9a19886
to
a365f40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves Web Platform Tests for Content Security Policy
inside shared workers, by:
Fixing a test with CSP: connect-src 'self' that could not fail
because of CORS requests being blocked independently of CSP.
Adding assertions that we raise securitypolicyviolation events for
CSP violations.
Adding a test for Content Security Policies in report-only mode.
While testing this, I noticed that debug versions of chrome would
crash when checking the disposition of a securitypolicyviolation event
from a Worker. This because of the thread-safety DCHECKs of
WTF::String. For addressing this, I needed to create new global static
strings "enforce" and "report".
Change-Id: I9c91b1a60eac82279dd74e8bb640dde2ada9cf6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2775564
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Cr-Commit-Position: refs/heads/master@{#870899}