Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of tilePatIdx #17

Closed
gatecat opened this issue Mar 17, 2021 · 2 comments
Closed

Use of tilePatIdx #17

gatecat opened this issue Mar 17, 2021 · 2 comments

Comments

@gatecat
Copy link
Collaborator

gatecat commented Mar 17, 2021

I can't find a use or purpose for the tilePatIdx field, it seems like it might be intended for some future graph folding work but if it's not currently being used then that should be made clear.
@litghost
Copy link
Contributor

I actually think it might be something we should just remove (for now). It's a property from RapidWright/Vivado, but it is undocumented.

@clavin-xlnx
Copy link
Contributor

Sure, from the RapidWright/Vivado perspective, its ok to remove. Since the device models don't need to be rebuilt in RapidWright from the Interchange, this won't be a problem.

@clavin-xlnx clavin-xlnx mentioned this issue Mar 29, 2021
Merged
litghost added a commit that referenced this issue Mar 30, 2021
@litghost
Merge pull request #21 from clavin-xlnx/remove_tile_pat_idx
e86e676 
Removing tile pattern index for now, resolves Issue #17.
litghost added a commit that referenced this issue Mar 30, 2021
@litghost
Revert "Removing tile pattern index for now, resolves Issue #17."
5535fe6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@litghost @clavin-xlnx @gatecat