Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_if_rest_of_carry4_is_unused: assert cell_idx < len(O_ports) - 1 #131

Closed
tcal-x opened this issue Mar 20, 2021 · 12 comments · Fixed by #135
Closed

check_if_rest_of_carry4_is_unused: assert cell_idx < len(O_ports) - 1 #131

tcal-x opened this issue Mar 20, 2021 · 12 comments · Fixed by #135
Assignees
@litghost @acomodi
Labels
bug Something isn't working

Comments

@tcal-x
Copy link
Contributor

tcal-x commented Mar 20, 2021

I encountered this using the symbiflow-examples installation and attempting to use it to build a LiteX SoC.

I added some debugging in the script; there were 4 O_ports, and cell_idx was 3.

I'll attach the testcase as a tarfile here.
@issuelabeler issuelabeler bot added the bug Something isn't working label Mar 20, 2021
@tcal-x
Copy link
Contributor Author

tcal-x commented Mar 20, 2021 

16. Executing JSON backend.
ERROR: TCL interpreter returned an error: Traceback (most recent call last):
  File "/media/tim/GIT/opt/symbiflow/xc7/install/share/symbiflow/scripts/fix_xc7_carry.py", line 605, in <module>
    main()
  File "/media/tim/GIT/opt/symbiflow/xc7/install/share/symbiflow/scripts/fix_xc7_carry.py", line 598, in main
    design, top_module, bit_to_cells, bit_to_nets, chain
  File "/media/tim/GIT/opt/symbiflow/xc7/install/share/symbiflow/scripts/fix_xc7_carry.py", line 559, in fixup_congested_rows
    check_if_rest_of_carry4_is_unused(cellname, cell_idx + 1):
  File "/media/tim/GIT/opt/symbiflow/xc7/install/share/symbiflow/scripts/fix_xc7_carry.py", line 508, in check_if_rest_of_carry4_is_unused
    assert cell_idx < len(O_ports) - 1
AssertionError

@tcal-x
Copy link
Contributor Author

tcal-x commented Mar 21, 2021

testcase131.tar.gz

To run the testcase, enter the SymbiFlow environment with $FPGA_FAM=xc7, ungzip/untar the test case, and source "source_me" in the directory.

@mithro
Copy link
Contributor

mithro commented Mar 24, 2021

@litghost / @acomodi - Can you take a look at this?

@litghost
Copy link
Contributor

I believe this was fixed in arch-defs already? f4pga/f4pga-arch-defs@61f7d23 That fix landed on January 24. @acomodi When was symbiflow-examples last updated? As part of the PCIe work, we need to push a new symbiflow-examples, so maybe good to wait until some more of the GTP stuff lands?

@tcal-x
Copy link
Contributor Author

tcal-x commented Mar 26, 2021

I believe this was fixed in arch-defs already? SymbiFlow/symbiflow-arch-defs@61f7d23 That fix landed on January 24. @acomodi When was symbiflow-examples last updated? As part of the PCIe work, we need to push a new symbiflow-examples, so maybe good to wait until some more of the GTP stuff lands?

Waiting is fine by me. I'll come back to this, but now I'm on Nexus stuff.

@acomodi
Copy link
Contributor

acomodi commented Mar 26, 2021

I have opened a PR to update the packages to the latest version.

so maybe good to wait until some more of the GTP stuff lands?

I think it is better to update them even before GTP stuff lands, as quite some things changed from the last time we updated the packages. As an example, we were still using the non-optimized VTR package.

@mithro
Copy link
Contributor

mithro commented Mar 26, 2021

@acomodi - What happened to the idea of having a bot auto-update these?

@tcal-x
Copy link
Contributor Author

tcal-x commented Mar 26, 2021

I attempted using SymbiFlow again after I applied the updates in PR #135. I ran into the following error regarding a missing tilegrid.json, although I probably made a mistake, since the CI for #135 is all green.

symbiflow_write_bitstream -d artix7 -f arty.fasm -p xc7a35tcsg324-1 -b arty.bit > /dev/null
Traceback (most recent call last):
  File "/media/tim/GIT/opt/symbiflow/xc7/conda/envs/xc7/bin/xcfasm", line 8, in <module>
    sys.exit(main())
  File "/media/tim/GIT/opt/symbiflow/xc7/conda/envs/xc7/lib/python3.7/site-packages/xc_fasm/xc_fasm.py", line 63, in main
    emit_pudc_b_pullup=args.emit_pudc_b_pullup)
  File "/media/tim/GIT/opt/symbiflow/xc7/conda/envs/xc7/lib/python3.7/site-packages/xc_fasm/fasm2frames.py", line 120, in fasm2frames
    assembler = fasm_assembler.FasmAssembler(db)
  File "/media/tim/GIT/opt/symbiflow/xc7/conda/envs/xc7/lib/python3.7/site-packages/prjxray/fasm_assembler.py", line 32, in __init__
    self.grid = db.grid()
  File "/media/tim/GIT/opt/symbiflow/xc7/conda/envs/xc7/lib/python3.7/site-packages/prjxray/db.py", line 152, in grid
    self._read_tilegrid()
  File "/media/tim/GIT/opt/symbiflow/xc7/conda/envs/xc7/lib/python3.7/site-packages/prjxray/db.py", line 133, in _read_tilegrid
    'tilegrid.json')) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/media/tim/GIT/opt/symbiflow/xc7/conda/envs/xc7/share/symbiflow/prjxray-db/artix7/xc7a35tcsg324-1/tilegrid.json'

There is a tilegrid.json at:

/media/tim/GIT/opt/symbiflow/xc7/conda/envs/xc7/share/symbiflow/prjxray-db/artix7/xc7a50t/tilegrid.json

...so I have a feeling I'm out of sync regarding the "all-parts" update.

@acomodi , is there something obvious that I missed applying the updates from #135? I did a "conda env update -f environment.yml", "pip install -r requirements.txt", and executed the "wget ..." commands.

@tcal-x
Copy link
Contributor Author

tcal-x commented Mar 26, 2021

@acomodi , never mind, I should try a clean install before you take a look.

@tcal-x
Copy link
Contributor Author

tcal-x commented Mar 30, 2021

@acomodi , I built my example after installing symbiflow-examples using your updates, and everything worked for me. I didn't see the original issue, and I didn't see the tilegrid issue that I mentioned.

@tcal-x tcal-x linked a pull request Mar 30, 2021 that will close this issue
xc7: update packages #135
Merged
@acomodi
Copy link
Contributor

acomodi commented Mar 30, 2021

@tcal-x great! I guess we can merge the update packages PR than

@tcal-x
Copy link
Contributor Author

tcal-x commented Mar 30, 2021

I merged the PR with the updates, but yes, auto-updating would be a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@litghost litghost

@acomodi acomodi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xc7: update packages antmicro/f4pga-examples
4 participants
@mithro @litghost @acomodi @tcal-x