Fix #8871: [OpenGL] Initialize all buffers after resize and clear back buffer. #8877
+38
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
reviewed
Mar 19, 2021
|
Fixes the issue for me (debug/MinGW/win32) |
LordAro
added
the
backport requested
|
This seems to fix the issue for me, running on the configuration in #8871 (Linux, SDL2, AMD Radeon R9 270). |
…ear back buffer.
michicc
force-pushed
the
pr/ogl_amd_buffer
branch
from
21cdc0d to
a402ba3
Compare
TrueBrain
approved these changes
Mar 20, 2021
2TallTyler
pushed a commit
to 2TallTyler/OpenTTD
that referenced
this pull request
Mar 29, 2021
…ear back buffer. (OpenTTD#8877)
TrueBrain
pushed a commit
to TrueBrain/OpenTTD
that referenced
this pull request
Mar 30, 2021
…ear back buffer. (OpenTTD#8877)
TrueBrain
pushed a commit
that referenced
this pull request
Apr 1, 2021
TrueBrain
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
On some driver/OS/GPU combinations, the back buffer (and maybe textures) get created with random contents, leading to an ugly display until the first proper full draw.
Description
Explicitly clear all texture buffers/back buffer and do a swap right after resize.
Limitations
I don't really see the reported behaviour on a Windows/nVidia system, so this fix is mostly speculation and needs (just like all 3D driver related things) testing on as many different systems as possible.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.