Fix #9440: negative cargo payments not being handled right #9455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Fixes #9440; negative cargo payments causing huge payments.
Description
Limitations
First and major question is whether it is wanted that cargo payments can be negative. The specifications do not seem to be very clear about it, though the custom cargo calculation allowing negative factors might imply that the cargo payments themselves can be negative.
So, this makes it possible and seemingly work for the graphs and actual payment, but I'm far from certain it should be this way. So closing this PR and #9440 as not-a-bug would be a valid solution as well.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.