Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] tor: 0.4.3.6 -> 0.4.4.6 #104365

Merged
merged 3 commits into from Nov 20, 2020
Merged

[20.09] tor: 0.4.3.6 -> 0.4.4.6 #104365

merged 3 commits into from Nov 20, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Nov 20, 2020 •
edited

Motivation for this change

Security update
Fixes TROVE-2020-005. (https://trac.torproject.org/projects/tor/wiki/TROVE)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak mentioned this pull request Nov 20, 2020
Merged
10 tasks
@prusnak prusnak added 1.severity: security 8.has: port to stable A PR already has a backport to the stable release. labels Nov 20, 2020
@mweinelt
Copy link
Member

You should probably just pick these three commits as they happend on master: c1ed88e, b1c4352 and 4c0678c.

prusnak and others added 3 commits November 20, 2020 13:48
@prusnak
tor: 0.4.3.6 -> 0.4.4.5
584cc91 
(cherry picked from commit c1ed88e)
@doublec @prusnak
tor: remove myself as maintainer
0aba51e 
(cherry picked from commit b1c4352)
@prusnak
tor: 0.4.4.5 -> 0.4.4.6
a6883b4 
(cherry picked from commit 4c0678c)
@prusnak
Copy link
Member Author

prusnak commented Nov 20, 2020

You should probably just pick these three commits as they happend on master: c1ed88e, b1c4352 and 4c0678c.

Updated the PR

@mweinelt mweinelt changed the title tor: 0.4.3.6 -> 0.4.4.6 [20.09] tor: 0.4.3.6 -> 0.4.4.6 Nov 20, 2020
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 104365 1

5 packages built:
  • onionshare
  • onionshare-gui
  • tor
  • torchat
  • whirlpool-gui

@mweinelt mweinelt merged commit 7c17479 into NixOS:release-20.09 Nov 20, 2020
@prusnak prusnak deleted the tor-20.09 branch November 20, 2020 14:36
@prusnak prusnak mentioned this pull request Dec 7, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@joachifm joachifm Awaiting requested review from joachifm

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @mweinelt @doublec