Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is pam_unix required, even if unixAuth = false #104346

Closed
wants to merge 1 commit into from

Conversation

Rudi9719
Copy link

This is more of a proposal/question than an actual pull request. Not sure how to actually test it!

Motivation for this change

I was unable to set security.pam.services.sshd.unixAuth to false, and was having issues with SDDM/SSSD previously #94744 then I noticed no matter what, pam_unix.so was marked as required. Even if unixAuth = false.

Things done

Wrapped all * required pam_unix.so in optionalString's based on other lines I saw in this file. Not sure if that would fix my problem or not, hoping someone who knows more about NixOS could weigh in. I'd also like to note that SSSD worked with SSH/Console log in out of the box when I opened #94744 and are now both borked for some reason.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Nov 20, 2020

Our whole PAM situation is in dire need of a refactor, and much more tests.

See #90490 (comment) for pointers and #90640 for details.

I'm pretty sure there are some interesting corner cases not handled properly.

@Rudi9719
Copy link
Author

@flokli what would you suggest? I'm not sure how exactly to help, as it apparently the tests didn't like what I tried to do

@stale
Copy link

stale bot commented Jun 4, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 4, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 12, 2023
Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rudi9719 are you still interested in fixing this and getting it merged? I will close it in a few weeks if you aren't anymore.

@Janik-Haag
Copy link
Member

I'll close this since @Rudi9719 seems to be mostly inactive. Feel free to reopen it or do a new one as soon as you have to again :D

Still thank you for your contribution

@Janik-Haag Janik-Haag closed this Jul 9, 2023
@Rudi9719
Copy link
Author

Rudi9719 commented Jul 9, 2023

I had to switch to a more stable distro and haven't had time to circle back and test updates- this branch is probably outdated

@Janik-Haag
Copy link
Member

as I said feel free to reopen as soon as you have time to work on it again :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants