Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: release-combined: only build the amazon image for x86_64,aarch… #104335

Merged
merged 1 commit into from Nov 20, 2020
Merged

nixos: release-combined: only build the amazon image for x86_64,aarch… #104335

merged 1 commit into from Nov 20, 2020

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Nov 20, 2020

…64-linux -- exclude i686

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member Author

grahamc commented Nov 20, 2020 

[grahamc@Petunia:~/projects/github.com/NixOS/nixpkgs]$ nix-instantiate ./nixos/release-combined.nix -A nixos.amazonImage.x86_64-linux -A nixos.amazonImage.aarch64-linux
warning: unknown setting 'extra-sandbox-paths'
warning: you did not specify '--add-root'; the result might be removed by the garbage collector
/nix/store/p53j5clb2yq328wbnyhpwqh5h10n82yv-nixos-amazon-image-21.03pre56789.gfedcba-x86_64-linux.drv
/nix/store/r25r4di9nzv4i1vh8g0ay0ilxns8s39f-nixos-amazon-image-21.03pre56789.gfedcba-aarch64-linux.drv

cole-h
cole-h approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. instantiates fine.

@cole-h cole-h added the 1.severity: channel blocker Blocks a channel label Nov 20, 2020
@grahamc grahamc merged commit e52ecd4 into NixOS:master Nov 20, 2020
@grahamc grahamc deleted the amazon-image-fixup2 branch November 20, 2020 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
1.severity: channel blocker Blocks a channel 6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grahamc @cole-h