Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdk-pixbuf: 2.40.0 → 2.42.0 #104337

Merged
merged 1 commit into from Nov 24, 2020
Merged

gdk-pixbuf: 2.40.0 → 2.42.0 #104337

merged 1 commit into from Nov 24, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 20, 2020

Motivation for this change

https://ftp.gnome.org/pub/GNOME/sources/gdk-pixbuf/2.42/gdk-pixbuf-2.42.0.news

xlib has been dropped, some build flags changed
Also corrected license.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    • the world depends on gdk-pixbuf so installed tests cannot be run without rebuilding it
  • ran with doCheck = true and it succeeded basically immediately, maybe we could enable it by default
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar added this to WIP in Staging via automation Nov 20, 2020
@jtojnar jtojnar moved this from WIP to Ready in Staging Nov 20, 2020
@jtojnar jtojnar added this to the 21.03 milestone Nov 20, 2020
@jtojnar jtojnar moved this from Ready to Needs review in Staging Nov 20, 2020
@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Nov 20, 2020
Staging automation moved this from Needs review to Ready Nov 23, 2020
@jtojnar jtojnar merged commit 2e110ba into NixOS:staging Nov 24, 2020
Staging automation moved this from Ready to Done Nov 24, 2020
@jtojnar jtojnar deleted the gdk-pixbuf-2.42 branch November 24, 2020 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@hedning hedning Awaiting requested review from hedning

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
Staging
  
Done
Milestone
21.05
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @SuperSandro2000