Fixes: unload-a-document tests do not respect wss variant #26586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 20, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2552078
branch
from
0091295
to
bd66b7f
Compare
tests in third_party/blink/web_tests/external/wpt/websockets/unload-a-document/ have wss variant. But when opening a popup, they don't pass the location.search parameter to their children. So for example, 001.html?wss will 001-1.html. And since 001-1.html has no knowledge of the wss param, it will (incorrectly) open an insecure sockets. Because of that, tests in websockets/unload-a-document always run the insecure variant. This patch fixes the issue. Bug: 801564 Change-Id: Ib88aa1c12dc6f8a390f650b164cd4cd203939a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552078 Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Arnaud Renevier <arenevier@fb.com> Cr-Commit-Position: refs/heads/master@{#830853}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2552078
branch
from
bd66b7f
to
024fe53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests in
third_party/blink/web_tests/external/wpt/websockets/unload-a-document/
have wss variant. But when opening a popup, they don't pass the
location.search parameter to their children. So for example,
001.html?wss will 001-1.html. And since 001-1.html has no knowledge of
the wss param, it will (incorrectly) open an insecure sockets.
Because of that, tests in websockets/unload-a-document always run the
insecure variant.
This patch fixes the issue.
Bug: 801564
Change-Id: Ib88aa1c12dc6f8a390f650b164cd4cd203939a43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552078
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Arnaud Renevier <arenevier@fb.com>
Cr-Commit-Position: refs/heads/master@{#830853}