-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{fprintd,libfprint}-tod: init, plus libfprint-2-tod1-goodix: init at 0.0.6 #104915
Conversation
I haven't run this exact expression on the laptop with the sensor yet. For future readers, something like:
is how you load the driver. You can debug with |
d508f87
to
e91b9e5
Compare
|
||
# for the curious, "tod" means "Touch OEM Drivers" meaning it can load | ||
# external .so's. | ||
libfprint.overrideAttrs ({ ... }: rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am very confused by this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! qyliss showed me this. overrideAttrs
takes a functions whose only argument is the original attributes you're overriding. Often you'll see overrideAttrs(old: { my overrides })
. Instead of calling it old, you can destructure the inputs by saying the function takes an attribute set, but the ...
means it ignores all of them.
Result of 3 packages built:
|
Hello @grahamc , thanks for this PR. Is there anything I can help with to get this out of the draft stage? I also have a XPS 9300, so I can help with any testing. |
How about you give it a test, reply with how you did it, and then we can
merge? Thanks!
On February 10, 2021, GitHub ***@***.***> wrote:
Hello @grahamc <https://github.com/grahamc> , thanks for this PR.
Is there anything I can help with to get this out of the draft stage?
I also have a XPS 9300, so I can help with any testing.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#104915 (comment)>,
or unsubscribe <https://github.com/notifications/unsubscribe-
auth/AAASXLB457R7WBGHMUFKN5LS6LUYZANCNFSM4UCVWBZQ>.
|
works great on a xps 9500 ! 👍
|
This is how I use it. And it works perfectly! Thanks!
overlay
PS: |
I'm using this for 2 weeks straight and there is no issues at all. I think it's pretty safe to merge this one. Thanks. |
@ofborg eval |
e91b9e5
to
5c1bbf5
Compare
5c1bbf5
to
65674c2
Compare
I updated this to use 1.90.7+tod1 and checked it works on nixos-unstable-small. |
I've raised a PR with a separate driver for Goodix 550a by Lenovo: #226056. Reviews appreciated. |
Motivation for this change
Fingerprint sensor support for the Dell XPS 9300.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)