Allow fixed-output derivations to depend on (floating) content-addressed ones #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edolstra
reviewed
Nov 26, 2020
| @@ -60,4 +60,15 @@ rec { | |||
| echo ${rootCA}/non-ca-hello > $out/dep | |||
| ''; | |||
| }; | |||
| dependentFixedOutput = mkDerivation { | |||
There was a problem hiding this comment.
Shouldn't there be a build of this attribute in tests/content-addressed.sh?
There was a problem hiding this comment.
Uh of course 🤦♂️
Fixed in 9bd8184
…sed ones Fix an overlook of NixOS#4056
thufschmitt
force-pushed
the
fixed-output-depending-on-ca
branch
from
39cfe5c
to
9bd8184
Compare
|
Oh it looks like this contained an older version of #4282 when that one was still being reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an overlook of #4056