Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] consul: 1.8.5 -> 1.8.6 #104916

Merged
merged 1 commit into from Nov 26, 2020
Merged

[20.09] consul: 1.8.5 -> 1.8.6 #104916

merged 1 commit into from Nov 26, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 25, 2020 •
edited

Motivation for this change

bug fixes and security patches

https://github.com/hashicorp/consul/releases

(cherry picked from commit c024d24)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit, nh2 and vdemeester November 25, 2020 17:43
nh2
nh2 approved these changes Nov 25, 2020
View reviewed changes
pkgs/servers/consul/default.nix Show resolved Hide resolved
@r-ryantm
consul: 1.8.0 -> 1.8.6
8bde0c4 
(cherry picked from commit c024d24)
@ofborg ofborg bot requested a review from nh2 November 25, 2020 22:26
@nh2
Copy link
Contributor

nh2 commented Nov 26, 2020

👍

@jonringer jonringer merged commit c929398 into NixOS:release-20.09 Nov 26, 2020
@jonringer jonringer deleted the backport-consul branch November 26, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@vdemeester vdemeester Awaiting requested review from vdemeester

@nh2 nh2 Awaiting requested review from nh2

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @nh2 @r-ryantm