Fix echo-content-escaped.py again #26645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix in #26615 only works in Py3. This time we make it compatible with Py2 & Py3.
wpt-pr-bot
requested review from
inexorabletash,
jdm,
mkruisselbrink and
zqzhang
stephenmcgruer
approved these changes
Nov 25, 2020
|
Oops, I was trying to be smart to avoid unnecessary backslashes, but turns out you can't a raw string literal that ends with a backslash since that'd escape the quote... |
|
In Python 3, this fix leaves the fallback case returning an |
Hexcles
added a commit
that referenced
this pull request
Nov 26, 2020
Hexcles
added a commit
that referenced
this pull request
Nov 26, 2020
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 4, 2020
…testonly Automatic update from web-platform-tests Fix echo-content-escaped.py for real (#26655) See web-platform-tests/wpt#26645 (comment) -- wpt-commits: fcb3495f6321b32f607cabcbe0e63a918f48d348 wpt-pr: 26655
sidvishnoi
pushed a commit
to sidvishnoi/gecko-webmonetization
that referenced
this pull request
Dec 10, 2020
…testonly Automatic update from web-platform-tests Fix echo-content-escaped.py for real (#26655) See web-platform-tests/wpt#26645 (comment) -- wpt-commits: fcb3495f6321b32f607cabcbe0e63a918f48d348 wpt-pr: 26655
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #26615 only works in Py3.
This time we make it compatible with Py2 & Py3.