Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.drivelib: init at 0.3.0, python3Packages.expiringdict: init at 1.2.1, git-annex-remote-googledrive: init at 1.3.0 #104919

Merged
merged 4 commits into from Apr 2, 2021
Merged

python3Packages.drivelib: init at 0.3.0, python3Packages.expiringdict: init at 1.2.1, git-annex-remote-googledrive: init at 1.3.0 #104919

merged 4 commits into from Apr 2, 2021

Conversation

gravndal
Copy link
Contributor

Motivation for this change

#46554 doesn't look to have gone anywhere.

I've never added any packages to nixpkgs before, do tell me if I missed anything.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104919 run on x86_64-linux 1

3 packages built:
  • gitAndTools.git-annex-remote-googledrive
  • python37Packages.drivelib
  • python38Packages.drivelib

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104919 run on x86_64-darwin 1

3 packages built:
  • gitAndTools.git-annex-remote-googledrive
  • python37Packages.drivelib
  • python38Packages.drivelib

@gravndal gravndal force-pushed the git-annex-remote-googledrive branch from 0ada1b0 to a5407b7 Compare January 8, 2021 05:15
@gravndal
Copy link
Contributor Author

Just noticed that the google-api-python-client package is broken:

Traceback (most recent call last):
  File "/nix/store/z9w9j2bhp4fimn1kcpw1ijyvzpgn5vib-git-annex-remote-googledrive-1.2.3/bin/.git-annex-remote-googledrive-wrapped", line 6, in <module>
    from git_annex_remote_googledrive.run import main
  File "/nix/store/z9w9j2bhp4fimn1kcpw1ijyvzpgn5vib-git-annex-remote-googledrive-1.2.3/lib/python3.8/site-packages/git_annex_remote_googledrive/run.py", line 22, in <module>
    from drivelib import __version__ as drivelib_version
  File "/nix/store/qpmhxwc88p0l59fy6ncpblkww879vh1s-drivelib-0.2.0/lib/python3.8/site-packages/drivelib/__init__.py", line 5, in <module>
    from .drive import *
  File "/nix/store/qpmhxwc88p0l59fy6ncpblkww879vh1s-drivelib-0.2.0/lib/python3.8/site-packages/drivelib/drive.py", line 15, in <module>
    from googleapiclient.discovery import build
  File "/nix/store/d7v837yx4mpi6arncnjjkgkgmppfzv8f-python3.8-google-api-python-client-1.12.8/lib/python3.8/site-packages/googleapiclient/discovery.py", line 68, in <module>
    from googleapiclient.http import build_http
  File "/nix/store/d7v837yx4mpi6arncnjjkgkgmppfzv8f-python3.8-google-api-python-client-1.12.8/lib/python3.8/site-packages/googleapiclient/http.py", line 67, in <module>
    from googleapiclient.model import JsonModel
  File "/nix/store/d7v837yx4mpi6arncnjjkgkgmppfzv8f-python3.8-google-api-python-client-1.12.8/lib/python3.8/site-packages/googleapiclient/model.py", line 30, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

It's missing a dependency on setuptools.

@gravndal gravndal mentioned this pull request Jan 12, 2021
Merged
10 tasks
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 104919 run on x86_64-darwin 1

4 packages built:
  • gitAndTools.git-annex-remote-googledrive
  • python37Packages.drivelib
  • python38Packages.drivelib
  • python39Packages.drivelib

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.drivelib:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python38Packages.drivelib:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python39Packages.drivelib:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@SuperSandro2000
Copy link
Member

Just noticed that the google-api-python-client package is broken:

I just merged the PR that fixes it.

@gravndal
Copy link
Contributor Author

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

* Tell pytest(CheckHook) where to find the tests included in the package

* Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to `fetchFromGitHub`.

* If the Packages does not contain any tests add 'doCheck = false;'`and a`pythonImportsCheck`.

Ah, I missed that, sorry. Had thought tests ran as the build never complained unlike with git-annex-remote-googledrive, and I see now that I confused the build output of tenacity as a part of drivelib.

Switching over to fetchFromGithub tests now run, but they (pretty obviously) need a google auth token to pass, so I'll disable them.

@gravndal gravndal force-pushed the git-annex-remote-googledrive branch from ae06496 to 01c7e64 Compare April 1, 2021 01:54
@gravndal gravndal changed the title pythonPackages.drivelib: init at 0.1.5, git-annex-remote-googledrive: init at 1.2.3 python3Packages.drivelib: init at 0.3.0, python3Packages.expiringdict: init at 1.2.1, git-annex-remote-googledrive: init at 1.3.0 Apr 1, 2021
@gravndal
Copy link
Contributor Author

gravndal commented Apr 1, 2021

Sorry about the delay here.

@gravndal gravndal force-pushed the git-annex-remote-googledrive branch from 01c7e64 to e9f12cd Compare April 1, 2021 21:08
@SuperSandro2000 SuperSandro2000 merged commit 5a41d75 into NixOS:master Apr 2, 2021
@gravndal gravndal deleted the git-annex-remote-googledrive branch April 2, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gravndal @SuperSandro2000