[LargestContentfulPaint] Fix invisible image tracking #26648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 25, 2020
In this CL we change |invisible_images_| to track not just LayoutObject but also the ImageResourceContent, which is in line with how it is tracked in |visible_images_| and is necessary to correctly track background images as well as image source changes that do not impact the LayoutObject used. Bug: 1152846 Change-Id: I2bfa02ef0a6795b7036abecf8f1e342f39e6ea3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561270 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#831333}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2561270
branch
from
c7d1c47
to
5ec9cd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this CL we change |invisible_images_| to track not just LayoutObject
but also the ImageResourceContent, which is in line with how it is
tracked in |visible_images_| and is necessary to correctly track
background images as well as image source changes that do not impact
the LayoutObject used.
Bug: 1152846
Change-Id: I2bfa02ef0a6795b7036abecf8f1e342f39e6ea3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561270
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831333}