Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyutils: fix build with llvm/clang #104930

Merged
merged 2 commits into from Jan 30, 2022
Merged

keyutils: fix build with llvm/clang #104930

merged 2 commits into from Jan 30, 2022

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Nov 25, 2020

Motivation for this change

clang build currently fails because the code contains an unused function.
The patch has also been sent upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka
Copy link
Contributor Author

kampka commented Nov 25, 2020

@GrahamcOfBorg build keyutils

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 25, 2020 •
edited

Result of nixpkgs-review pr 104930 run on x86_64-darwin 1

12 packages marked as broken and skipped:
  • almanah
  • atom
  • atom-beta
  • gnome-recipes
  • gnome3.nautilus-python
  • haskellPackages.libzfs
  • mate.mate-utils
  • python27Packages.keyutils
  • python37Packages.keyutils
  • python38Packages.keyutils
  • sanoid
  • udiskie

Probably some of those packages should probably be looked at.

@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 3, 2022
@kampka
Copy link
Contributor Author

kampka commented Jan 5, 2022

@SuperSandro2000 MInd taking another look?

@kampka kampka force-pushed the keyutils branch 2 times, most recently from 040d732 to 08d5edc Compare January 17, 2022 10:01
@SuperSandro2000
Copy link
Member

and now that needs to go to staging...

@kampka kampka changed the base branch from master to staging January 17, 2022 12:38
@kampka
Copy link
Contributor Author

kampka commented Jan 21, 2022

@SuperSandro2000 ping :)

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit 6715796 into NixOS:staging Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kampka @SuperSandro2000