youtube-dl: 2020.11.24 -> 2020.11.26 #104931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luflosi
added
the
9.needs: port to stable
ofborg
bot
requested review from
fpletz,
Enzime,
Ma27,
Phreedom and
AndersonTorres
|
Result of 3 packages failed to build:
35 packages built:
|
lukegb
approved these changes
Nov 25, 2020
There was a problem hiding this comment.
youtube-dl doesn't seem to run in that environment though, I get
Traceback (most recent call last):
File "/nix/store/mw9hjrzgd81qbdq4anscpxgsc0j46my2-python3.8-youtube-dl-2020.11.26/bin/.youtube-dl-wrapped", line 6, in <module>
from youtube_dl import main
File "/nix/store/ka6q3w2vyj979jp0iqc86ddnb5xvczcz-python3.7-youtube-dl-2020.11.26/lib/python3.7/site-packages/youtube_dl/__init__.py", line 15, in <module>
from .options import (
File "/nix/store/ka6q3w2vyj979jp0iqc86ddnb5xvczcz-python3.7-youtube-dl-2020.11.26/lib/python3.7/site-packages/youtube_dl/options.py", line 8, in <module>
from .downloader.external import list_external_downloaders
File "/nix/store/ka6q3w2vyj979jp0iqc86ddnb5xvczcz-python3.7-youtube-dl-2020.11.26/lib/python3.7/site-packages/youtube_dl/downloader/__init__.py", line 5, in <module>
from .hls import HlsFD
File "/nix/store/ka6q3w2vyj979jp0iqc86ddnb5xvczcz-python3.7-youtube-dl-2020.11.26/lib/python3.7/site-packages/youtube_dl/downloader/hls.py", line 6, in <module>
from Crypto.Cipher import AES
File "/nix/store/4p0d9jzgfn0xj2sbqb1clahxmq2g1s9s-python3.7-pycryptodome-3.9.9/lib/python3.7/site-packages/Crypto/Cipher/__init__.py", line 27, in <module>
from Crypto.Cipher._mode_ecb import _create_ecb_cipher
File "/nix/store/4p0d9jzgfn0xj2sbqb1clahxmq2g1s9s-python3.7-pycryptodome-3.9.9/lib/python3.7/site-packages/Crypto/Cipher/_mode_ecb.py", line 35, in <module>
raw_ecb_lib = load_pycryptodome_raw_lib("Crypto.Cipher._raw_ecb", """
File "/nix/store/4p0d9jzgfn0xj2sbqb1clahxmq2g1s9s-python3.7-pycryptodome-3.9.9/lib/python3.7/site-packages/Crypto/Util/_raw_api.py", line 308, in load_pycryptodome_raw_lib
raise OSError("Cannot load native module '%s': %s" % (name, ", ".join(attempts)))
OSError: Cannot load native module 'Crypto.Cipher._raw_ecb': Trying '_raw_ecb.cpython-38-x86_64-linux-gnu.so': /nix/store/4p0d9jzgfn0xj2sbqb1clahxmq2g1s9s-python3.7-pycryptodome-3.9.9/lib/python3.7/site-packages/Crypto/Util/../Cipher/_raw_ecb.cpython-38-x86_64-linux-gnu.so: cannot open shared object file: No such file or directory, Trying '_raw_ecb.abi3.so': /nix/store/4p0d9jzgfn0xj2sbqb1clahxmq2g1s9s-python3.7-pycryptodome-3.9.9/lib/python3.7/site-packages/Crypto/Util/../Cipher/_raw_ecb.abi3.so: cannot open shared object file: No such file or directory, Trying '_raw_ecb.so': /nix/store/4p0d9jzgfn0xj2sbqb1clahxmq2g1s9s-python3.7-pycryptodome-3.9.9/lib/python3.7/site-packages/Crypto/Util/../Cipher/_raw_ecb.so: cannot open shared object file: No such file or directory
which is incredibly suspicious because there's both a python3.8 and python3.7 youtube-dl hanging out there.
Anyway, unsetting PYTHONPATH and running ./results/youtube-dl/bin/youtube-dl on a Spreaker URL (new in this release) seems to work properly, so LGTM.
|
@AndersonTorres can you also take care of the backport? :) |
|
@Ma27 looks fine but I never dit it before. Do you have a link to a tutorial or something? |
https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes |
|
Result of 5 packages marked as broken and skipped:
4 packages failed to build:
19 packages built:
Broken packages are either already fixed or require youtube-dlc |
|
Was backported in 9396030. |
erictapen
added
8.has: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/ytdl-org/youtube-dl/releases/tag/2020.11.26
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)