Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocaml-migrate-parsetree: 1.7.3 → 1.8.0; add ocaml-migrate-parsetree 2.1.0 #104902

Merged
merged 3 commits into from Nov 28, 2020
Merged

ocaml-migrate-parsetree: 1.7.3 → 1.8.0; add ocaml-migrate-parsetree 2.1.0 #104902

merged 3 commits into from Nov 28, 2020

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Nov 25, 2020 •
edited

Motivation for this change
  • Update default ocaml-migrate-parsetree version to 1.8.0 which adds (limited) support for OCaml 4.12
  • Add the most recent version of ocaml-migrate-parsetree as ocaml-migrate-parsetree-2-1 which is required by some newer packages (for example if we want to upgrade to cstruct 6.0.0)

cc @vbgl

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build ocamlPackages.lwt

@vbgl
Copy link
Contributor

vbgl commented Nov 25, 2020

@GrahamcOfBorg build acgtk beluga dune-release eff flow framac fstar jackline liquidsoap ocaml-crunch ocamlformat ocamlformat_0_11_0 ocamlformat_0_12 ocamlformat_0_13_0 ocamlformat_0_14_0 ocamlformat_0_14_1 ocamlformat_0_14_2 ocamlformat_0_14_3 ocamlformat_0_15_0 patdiff reason satysfi stog

@vbgl
Copy link
Contributor

vbgl commented Nov 26, 2020

Merged the OMP update to 1.8.0 as f8bab20, slightly amended to disable ppx_sqlexpr for OCaml 4.05.

@vbgl
Copy link
Contributor

vbgl commented Nov 27, 2020

Merged the new OMP at 2.1.0 as c6a8fcd, slightly amended to fetch the release artifact (with correct version information in the META file) rather than the git sources.

@vbgl vbgl merged commit 78d2aa5 into NixOS:master Nov 28, 2020
@sternenseemann sternenseemann deleted the ocaml-migrate-parsetree-2.1.0 branch November 28, 2020 15:42
@sternenseemann sternenseemann restored the ocaml-migrate-parsetree-2.1.0 branch July 24, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @vbgl