Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifont: 13.0.01 -> 13.0.04 #104921

Merged
merged 1 commit into from Nov 25, 2020
Merged

unifont: 13.0.01 -> 13.0.04 #104921

merged 1 commit into from Nov 25, 2020

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Nov 25, 2020

Motivation for this change

The dependency to libfaketime seems unnecessary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka
Copy link
Contributor Author

kampka commented Nov 25, 2020

@GrahamcOfBorg build unifont

@kampka kampka requested review from lsix and rnhmjoj November 25, 2020 18:38
@ofborg ofborg bot requested review from vrthra and rycee November 25, 2020 18:48
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Nov 25, 2020

The dependency to libfaketime seems unnecessary.

It's not strictly necessary but it makes the build deterministic.

@kampka
Copy link
Contributor Author

kampka commented Nov 25, 2020

@rnhmjoj Thanks for clarifying, dropped the commit 👍

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104921 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixosTest-test
8 packages built:
  • grub2 (grub2_full)
  • grub2_efi
  • grub2_light
  • grub2_pvgrub_image
  • grub2_xen
  • os-prober
  • unifont
  • woeusb

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104921 run on x86_64-darwin 1

1 package built:
  • unifont

@SuperSandro2000 SuperSandro2000 merged commit 892f9b6 into NixOS:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix Awaiting requested review from lsix

@rnhmjoj rnhmjoj Awaiting requested review from rnhmjoj

@vrthra vrthra Awaiting requested review from vrthra

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kampka @rnhmjoj @SuperSandro2000