Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/networking: Alleviate race in scripted test #104923

Merged
merged 1 commit into from Nov 25, 2020
Merged

nixos/tests/networking: Alleviate race in scripted test #104923

merged 1 commit into from Nov 25, 2020

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Nov 25, 2020 •
edited

This step often failed both locally and on Hydra. This change appears to greatly alleviate it on machines that are not very busy at least.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb
Copy link
Contributor

lukegb commented Nov 25, 2020

This seems reasonable: setting the MTU on these interfaces is, iirc, controlled by the .link files and based off a udev trigger. I don't know if there's a better way to make sure that's happened.

@lukegb
Copy link
Contributor

lukegb commented Nov 25, 2020

@ofborg test networking.networkd.virtual networking.scripted.virtual

@srhb
Copy link
Contributor Author

srhb commented Nov 25, 2020

Fun, that's a different failure. I don't think it's related.

@ofborg test networking.networkd.virtual networking.scripted.virtual

@lukegb
Copy link
Contributor

lukegb commented Nov 25, 2020

Hah, yeah, looks like that's a different flake. Turns out sleeping 10 seconds does not a reliable test make...

@srhb
Copy link
Contributor Author

srhb commented Nov 25, 2020

Who would have thought! :D

@srhb srhb merged commit 3c49984 into NixOS:master Nov 25, 2020
@srhb srhb deleted the unrace-scripted branch November 25, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukegb lukegb lukegb approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srhb @lukegb